RocketChat / RocketChat/Rocket.Chat

Long mongodb queries in 4.X versions

Open
#24,512 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

This issue is to @sampaiodiego and other back-end team members to consider.
It's about optimizing some back-end stuff like queries and indexes.
Previous similar issue was https://github.com/RocketChat/Rocket.Chat/issues/23052 and it was fixed in 3.18.1

But now in 4.X versions I see some long queries. Not so long, like it was before, but they definitely could be optimized by team.

Steps to reproduce:

Hard to tell. It I find them, I will update.

Expected behavior:

Optimized queries and optimized indexes

Actual behavior:

Lots of peaks on graph
image

Server Setup Information:
  • Version of Rocket.Chat Server: 4.3.3
  • Operating System: OL8.5
  • Deployment Method: docker
  • Number of Running Instances: 20
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 12.22.8
  • MongoDB Version: 4.4.12
Client Setup Information
  • Desktop App or Browser Version: 3.7.7
  • Operating System: Windows 10
Additional context

I'm plan to collect such long queries in that thread to team investigation

Relevant logs:

First I see this long query. I see it is something in rocketchat.rocketchat_message collection and something with unread function. And 88332 in docsExamined it's pretty large amount to handle.

There is a almost 90k messages in that private chat
image

{"t":{"$date":"2022-02-15T11:22:27.947+03:00"},"s":"I",  "c":"WRITE",    "id":51803,   "ctx":"conn275","msg":"Slow query","attr":{"type":"update","ns":"rocketchat.rocketchat_message","command":{"q":{"rid":"hoYsQrcqNQRkHiyKz","unread":true,"ts":{"$lt":{"$date":"2022-02-11T12:57:02.685Z"}}},"u":{"$unset":{"unread":1},"$set":{"_updatedAt":{"$date":"2022-02-15T08:22:27.015Z"}}},"multi":true,"upsert":false},"planSummary":"IXSCAN { rid: 1, ts: 1, _updatedAt: 1 }","keysExamined":88332,"docsExamined":88332,"fromMultiPlanner":true,"replanned":true,"replanReason":"cached plan was less efficient than expected: expected trial execution to take 141 works but it took at least 1410 works","nMatched":0,"nModified":0,"numYields":443,"queryHash":"ECEA286E","planCacheKey":"818ECB28","locks":{"ParallelBatchWriterMode":{"acquireCount":{"r":444}},"ReplicationStateTransition":{"acquireCount":{"w":444}},"Global":{"acquireCount":{"w":444}},"Database":{"acquireCount":{"w":444}},"Collection":{"acquireCount":{"w":444}},"Mutex":{"acquireCount":{"r":1}}},"flowControl":{"acquireCount":444,"timeAcquiringMicros":196},"storage":{},"durationMillis":931}}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the slow-query log for the rocketchat.rocketchat_message collection and the referenced issue 23052; the report provides no source file or test entry point. Gather the affected unread queries and indexes, then confirm that the documented query peaks and high docsExamined counts are reduced.

Written by the indexing model from the issue text.

Assessment

Tech stack
mongodb
Domain
backend, databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.