RocketChat / RocketChat/Rocket.Chat
v4.3.3 --> v4.4.2 upgrade errors
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
several errors is displayed when upgrading from v4.3.3 to v4.4.2
Steps to reproduce:
sudo systemctl stop rocketchat
sudo rm -rf /opt/rocket/Rocket.Chat
sudo n install 14.18.2
curl -L https://releases.rocket.chat/latest/download -o /tmp/rocket.chat.tgz
tar -xzf /tmp/rocket.chat.tgz -C /tmp
cd /tmp/bundle/programs/server && npm install
sudo mv /tmp/bundle /opt/rocket/Rocket.Chat
sudo chown -R rocket:rocket /opt/rocket/Rocket.Chat
sudo systemctl start rocketchat
Expected behavior:
v4.3.3 to be upgraded to v4.4.2
Actual behavior:
npm WARN deprecated node-pre-gyp@0.15.0: Please upgrade to @mapbox/node-pre-gyp: the non-scoped node-pre-gyp package is deprecated and only the @mapbox scoped package will recieve updates in the future
fibers@https://github.com/meteor/node-fibers/archive/refs/tags/5.0.0-1.tar.gz install /tmp/bundle/programs/server/node_modules/fibers
node build.js || nodejs build.js
make: Entering directory '/tmp/bundle/programs/server/node_modules/fibers/build'
CXX(target) Release/obj.target/fibers/src/fibers.o
../src/fibers.cc: In function ‘void uni::SetAccessor(v8::Isolate*, v8::Localv8::Object, v8::Localv8::String, uni::FunctionType ()(v8::Localv8::String, const GetterCallbackInfo&), void ()(v8::Localv8::String, v8::Localv8::Value, const SetterCallbackInfo&))’:
../src/fibers.cc:355:87: warning: cast between incompatible function types from ‘uni::FunctionType ()(v8::Localv8::String, const GetterCallbackInfo&)’ {aka ‘void ()(v8::Localv8::String, const v8::PropertyCallbackInfov8::Value&)’} to ‘v8::AccessorNameGetterCallback’ {aka ‘void ()(v8::Localv8::Name, const v8::PropertyCallbackInfov8::Value&)’} [-Wcast-function-type]
355 | object->SetAccessor(isolate->GetCurrentContext(), name, (AccessorNameGetterCallback)getter, (AccessorNameSetterCallback)setter).ToChecked();
| ^~~~~~
../src/fibers.cc:355:123: warning: cast between incompatible function types from ‘void ()(v8::Localv8::String, v8::Localv8::Value, const SetterCallbackInfo&)’ {aka ‘void ()(v8::Localv8::String, v8::Localv8::Value, const v8::PropertyCallbackInfo&)’} to ‘v8::AccessorNameSetterCallback’ {aka ‘void ()(v8::Localv8::Name, v8::Localv8::Value, const v8::PropertyCallbackInfo&)’} [-Wcast-function-type]
355 | object->SetAccessor(isolate->GetCurrentContext(), name, (AccessorNameGetterCallback)getter, (AccessorNameSetterCallback)setter).ToChecked();
| ^~~~~~
In file included from ../src/coroutine.h:1,
from ../src/fibers.cc:1:
../src/fibers.cc: At global scope:
/root/.cache/node-gyp/14.18.2/include/node/node.h:787:43: warning: cast between incompatible function types from ‘void ()(v8::Localv8::Object)’ to ‘node::addon_register_func’ {aka ‘void ()(v8::Localv8::Object, v8::Localv8::Value, void*)’} [-Wcast-function-type]
787 | (node::addon_register_func) (regfunc),
| ^
/root/.cache/node-gyp/14.18.2/include/node/node.h:821:3: note: in expansion of macro ‘NODE_MODULE_X’
821 | NODE_MODULE_X(modname, regfunc, NULL, 0) // NOLINT (readability/null_usage)
| ^~~~~~~~~~~~~
../src/fibers.cc:930:1: note: in expansion of macro ‘NODE_MODULE’
930 | NODE_MODULE(fibers, init)
| ^~~~~~~~~~~
CXX(target) Release/obj.target/fibers/src/coroutine.o
CC(target) Release/obj.target/fibers/src/libcoro/coro.o
SOLINK_MODULE(target) Release/obj.target/fibers.node
COPY Release/fibers.node
make: Leaving directory '/tmp/bundle/programs/server/node_modules/fibers/build'
Installed in /tmp/bundle/programs/server/node_modules/fibers/bin/linux-x64-83-glibc/fibers.node
npm WARN lifecycle meteor-dev-bundle@~install: cannot run in wd meteor-dev-bundle@ node npm-rebuild.js (wd=/tmp/bundle/programs/server)
added 157 packages from 85 contributors and audited 157 packages in 10.548s
4 packages are looking for funding
run npm fund for details
found 0 vulnerabilities

Server Setup Information:
Ubuntu 20.04.3 LTS
Rocket.Chat Version 4.3.3
Node-Version v12.22.9
Datenbankmigration 252 (12. Februar 2022 11:44)
MongoDB 4.2.18 / wiredTiger (oplog Aktiviert)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the upgrade on Ubuntu 20.04 using the listed systemd, Node.js, bundle extraction, and npm commands, then capture the complete startup result. Inspect the fibers build output and meteor-dev-bundle npm warning first; done means the Rocket.Chat 4.3.3 installation upgrades to 4.4.2 and starts successfully without the reported errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mongodb, node.js
- Domain
- backend, build-system, devops
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100