RocketChat / RocketChat/Rocket.Chat
[IMPROVE] Provide Notification Sound Preview While Changing It From Account/preferences
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
It is always a good user experience if we play a sound when the user changes the notification sound so that he/she can check the sound before saving it
Steps to reproduce:
- Go To Account/preferences
- Inside Sound Section Change the New Room or New message notification Sound
- While changing it' it's not playing sound
Expected behavior:
When the user changes the sound for Room or new Message, we should play sound so that he understands which sound is better and then can apply changes and save it.
Actual behavior:
When the user changes the sound, no sound play when he change it.
Server Setup Information:
- Version of Rocket.Chat Server: 4.5.0
- Operating System:
- Deployment Method:
- Number of Running Instances:
- DB Replicaset Oplog:
- NodeJS Version: 14.18.2
- MongoDB Version: 4.4.4
Client Setup Information
- Desktop App or Browser Version:
- Operating System:
Additional context
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Account/preferences and inspect the Sound section handling changes to the New Room and New message notification sounds. Trace how the selected sound is represented and played, then verify that changing either selection previews it before saving; confirm the behavior with the relevant frontend tests if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100