RocketChat / RocketChat/Rocket.Chat

[IMPROVE] Provide Notification Sound Preview While Changing It From Account/preferences

Open
#24,455 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

It is always a good user experience if we play a sound when the user changes the notification sound so that he/she can check the sound before saving it

Steps to reproduce:
  1. Go To Account/preferences
  2. Inside Sound Section Change the New Room or New message notification Sound
  3. While changing it' it's not playing sound
Expected behavior:

When the user changes the sound for Room or new Message, we should play sound so that he understands which sound is better and then can apply changes and save it.

Actual behavior:

When the user changes the sound, no sound play when he change it.

https://user-images.githubusercontent.com/53515714/153142074-70a9519e-c7d4-4667-942a-ba8331019f42.mp4

Server Setup Information:
  • Version of Rocket.Chat Server: 4.5.0
  • Operating System:
  • Deployment Method:
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • NodeJS Version: 14.18.2
  • MongoDB Version: 4.4.4
Client Setup Information
  • Desktop App or Browser Version:
  • Operating System:
Additional context
Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at Account/preferences and inspect the Sound section handling changes to the New Room and New message notification sounds. Trace how the selected sound is represented and played, then verify that changing either selection previews it before saving; confirm the behavior with the relevant frontend tests if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.