RocketChat / RocketChat/Rocket.Chat

Outgoing webhook not impersonating user

Open
#24,442 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

With 4.4.0, responses to outgoing webhooks were broken entirely. Now with 4.4.1, it seems that they process the response properly, but the user the response is sent by is rocket.chat even with impersonation enabled

Steps to reproduce:
  1. Create simple outgoing webhook with impersonation enabled and user set to root
  2. trigger outgoing webhook
  3. observe that the response is sent by rocket.chat
Expected behavior:

the response should be sent by the user who triggered the outgoing webhook

Actual behavior:

rocket.cat posts the response

Server Setup Information:
  • Version of Rocket.Chat Server: 4.4.1
  • Operating System: Docker
  • Deployment Method: Docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version:
  • MongoDB Version: 4.4
Client Setup Information
  • Desktop App or Browser Version: Latest Firefox/Edge tested
  • Operating System: Windows 10
Relevant logs:

I did not see any errors in server logs or browser console logs

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue using an outgoing webhook with impersonation enabled and the user set to root, then inspect the outgoing webhook response-handling entry point. Done means the response is posted by the user who triggered the webhook rather than Rocket.Chat, with no server or browser errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.