RocketChat / RocketChat/Rocket.Chat
[BUG] Should Display appropriate Message
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
When there are no messages to prune, It should give the appropriate response.
Steps to reproduce:
- Go to any Channel
- Click on Prune Messages on the top right
- set the time periods where no message exists to prune
- prune all messages or any particular user messages
- It will show an undefined error
Expected behavior:
When there is no message to prune for given time periods, we should display an appropriate message.
Actual behavior:
It showing undefined if there is no message to prune.
Server Setup Information:
- Version of Rocket.Chat Server: 4.5.0
- Operating System: linux
- Deployment Method:
- Number of Running Instances:
- DB Replicaset Oplog:
- NodeJS Version: 14.18.2
- MongoDB Version: 4.4.4
Client Setup Information
- Desktop App or Browser Version:
- Operating System:
Additional context
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by opening a channel, selecting Prune Messages, and choosing a period with no matching messages. Trace the prune-message UI and its handling of the empty result that currently appears as undefined. Done means an appropriate no-messages response is shown for both all-message and user-specific pruning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100