RocketChat / RocketChat/Rocket.Chat
Upgrading to 4.3.2 got npm security warning
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
I upgraded to 4.3.2 tonight and during the process, npm reported a vulnerability with a package.
=== npm audit security report ===
# Run npm install underscore@1.13.2 to resolve 1 vulnerability
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High │ Arbitrary Code Execution in underscore │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ underscore │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ underscore │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ underscore │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://github.com/advisories/GHSA-cf4h-3jhx-xvhq │
└───────────────┴──────────────────────────────────────────────────────────────┘
I ran the "fix" command and that downgraded the package.
Is this a concern?
Steps to reproduce:
- Presumably, this happens when upgrading
Expected behavior:
Packages can be updated without security warnings.
Actual behavior:
See description.
Server Setup Information:
- Version of Rocket.Chat Server: 4.3.2
- Operating System: Linux
- Deployment Method: manual
- Number of Running Instances: 1
- DB Replicaset Oplog:
- NodeJS Version: v12.22.1
- MongoDB Version: 4.2.12
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the npm audit report for Rocket.Chat 4.3.2 and inspect the project’s dependency manifests to locate the direct underscore dependency. Confirm whether the supported dependency version removes the warning without the reported downgrade, then rerun the relevant npm audit check to verify that the vulnerability is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100