RocketChat / RocketChat/Rocket.Chat
Links of files from FileSideBar remains unchanged after changing the Site URL
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
I changed the reverse proxy url of rocket, say from chat.***.com to chat.***.dev,and changed the Site URL from the rocket's administration-General-SiteUrl settings accordingly. Everything works fine but the FileSideBar, which still points files to the old url.
The file in the message side is correctly changed to
https://chat.***.dev/file-upload/[fileID]/[filename]?download
but the file in the FileSideBar remains
https://chat.***.com/ufs/FileSystem:Uploads/[fileID]/[filename]
If change the link manualy in the browser, I can download it.
Deployment
Version
4.3.0
Deployment ID
9TT3ahndFSEAChmtm
Apps Engine Version
1.29.0
Node Version
v12.22.8
Database Migration
252 (January 7, 2022 2:32 PM)
MongoDB
5.0.5 / wiredTiger (oplog Enabled)
Commit Details
HEAD: (9161223c6)
Branch: HEAD
PID
1
Client Setup Information
- Desktop App or Browser Version: Both
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the FileSideBar entry point that builds file links, then compare its URL construction with the message-side file-upload link described in the issue. Done means FileSideBar links use the current Site URL after it changes, while preserving the existing file identifier and filename behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100