RocketChat / RocketChat/Rocket.Chat
Notification text does not show attachement text
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
My Setup
- Operating System: Windows 7 Pro
- App Version: 2.16.2
- Server Version: 2.1.1
- Installation type: exe
- I have tested with the latest version
- I can simulate the issue easily
Description
We're using an Incoming Webhook with connection to a Gitlab instance to post messages to a channel.
The script we use is a slightly modified version from the one available here: https://rocket.chat/docs/administrator-guides/integrations/gitlab/
Since the messages from the webhook are posted via a "bot", the complete content of the message is stored as attachment (see makeAttachment() method in the script).
In function mergeRequestEvent(data), when the text: field of the returned content: element is empty, the desktop notification shows a message " uploaded a file".
This is a regression from older (server?) versions, as previously it would show the text from the attachment in the notification.
Current Behavior
The desktop notification for a message from an Incoming Gitlab Webhook does not display the message text, but "uploaded a file" instead.
Expected Behavior
The desktop notification for a message from an Incoming Gitlab Webhook shall consider the text defined in the attachment part of a message if the message text itself is empty.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the desktop notification handling for messages with empty text and attachments, using the reported mergeRequestEvent(data) and makeAttachment() entry points as context. Verify how the notification chooses its fallback text, then confirm that an attachment's text is shown when the message text is empty.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100