RocketChat / RocketChat/Rocket.Chat

Usernames instead of displayNames for random users

Open
#24,200 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:
Steps to reproduce:
  1. Install or update Rocket.Chat to version 4.3.1. Set display their full names instead of usernames.
  2. Sync users with LDAP
  3. Start chatting with people. Notice that some of them have their usernames instead of full names. But their full name is displayed correctly in the chat itself.
Expected behavior:

Display full name of users (their first name and last name) in the sidebar contact list and in chat header

Actual behavior:

Username (LDAP login) is displayed for random users in the sidebar contact list and in the header
rocketchat_usernames

Server Setup Information:
  • Version of Rocket.Chat Server: 4.3.1 (but has been there since at least 3.18)
  • Operating System: CentOS 7
  • Deployment Method: tar
  • Number of Running Instances: 3
  • DB Replicaset Oplog: enabled
  • NodeJS Version: v12.22.8
  • MongoDB Version: 4.4.9
Client Setup Information
  • Desktop App or Browser Version: Firefox 96.0.1 for instance (but is seen on any browser and latest app version)
  • Operating System: macOS, Windows, Linux
Additional context

We've compared normal user accounts with ones that have that bug and seen no difference in db.users table.

Relevant logs:

There are no relevant logs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with LDAP-synced users in Rocket.Chat 4.3.1, then compare the user data and rendering used by the sidebar contact list, chat header, and chat itself. Done means affected users consistently show their configured full names instead of LDAP usernames in the sidebar and header.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.