RocketChat / RocketChat/Rocket.Chat

[LDAP] ominous error message in logs - user not found - without stating username

Open
#23,949 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Following error message appears constantly in the Logs:

{"level":50,"time":"2021-12-15T06:27:01.796Z","pid":1,"hostname":"a98600e97b9c","name":"LDAP","err":{"type":"Error","message":"User not found","stack":"Error: User not found<br>    at server/lib/ldap/Manager.ts:166:11<br>    at /app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40"},"msg":"User not found"} 

Albeit this might be valid and true, but without stating the username I would like to consider the message as not complete – and therefore as a bug.

Steps to reproduce:

Have LDAP and Users. And possibly one user which is some kind of faulty, not existing anymore, or anything like this.

Expected behavior:

State the username in the error message

Actual behavior:

username is missing in the error message

Server Setup Information:
  • Version of Rocket.Chat Server: 4.2.2
  • Operating System: Fedora CoreOS
  • Deployment Method: docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 12.22.1
  • MongoDB Version: 5.0.5
Client Setup Information
  • Desktop App or Browser Version: both, but not relevant
  • Operating System: yes
Additional context

nothing else

Relevant logs:
{"level":50,"time":"2021-12-15T06:27:01.796Z","pid":1,"hostname":"a98600e97b9c","name":"LDAP","err":{"type":"Error","message":"User not found","stack":"Error: User not found<br>    at server/lib/ldap/Manager.ts:166:11<br>    at /app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40"},"msg":"User not found"} 

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect server/lib/ldap/Manager.ts around line 166, where the reported "User not found" error is raised. Reproduce the LDAP missing-user case and verify that the resulting log message identifies the affected username.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.