RocketChat / RocketChat/Rocket.Chat
[BUG] Marketplace App status button doesn't become invisible after exiting out of Cloud Registration Modal
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
When user isn't logged into cloud and clicks on any marketplace app, Cloud Registration Modal shows up, after clicking cancel, the status button still shows up even if the app isn't in focus anymore.Steps to reproduce:
- Go to Administration/Apps.
- Click on any app status button.
- When a modal shows up, click cancel and the status button still shows up.
Expected behavior:
The status button should become invisible after clicking cancel in modal.Actual behavior:
Server Setup Information:
- Version of Rocket.Chat Server: 4.3.0 -develop
- Operating System: WSL-2 (Windows)
- Deployment Method: Manual installation
- Number of Running Instances: 1
- DB Replicaset Oplog: Enabled
- NodeJS Version: 12.22.1 -x64
- MongoDB Version: 4.4.4 wiredTiger
Client Setup Information
- Desktop App or Browser Version: Chrome latest Version 96.0.4664.45
- Operating System: Windows 10 version 21H1
Additional context
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Administration/Apps by reproducing the Marketplace App status button flow while logged out of Cloud. Inspect the Cloud Registration Modal cancellation path and how it controls the button's visibility. Done means the status button becomes invisible after Cancel when the app is no longer in focus.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100