RocketChat / RocketChat/Rocket.Chat

[Bug] Error `undefined` on user deletion

Open
#23,680 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Sometimes user deletion process finishes with undefined error and there is no information that user successfully deleted.

Steps to reproduce:
  1. Delete user in Admin UI - Users
  2. Sometimes get error undefined
  3. Click Delete button in Are you sure? window
  4. Get another error [error-invalid-user]
Expected behavior:

User deleted without any errors

Actual behavior:

image
After press Delete another time
image

Server Setup Information:
  • Version of Rocket.Chat Server: 3.18.2
  • Operating System: CentOS7
  • Deployment Method: docker
  • Number of Running Instances: 20
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 12.22.1
  • MongoDB Version: 4.2.15
Client Setup Information
  • Desktop App or Browser Version: Chrome 95
  • Operating System: Windows 10
Additional context

In fact users seems to be deleted - I don't find that user in Admin UI on mongodb, but that edge case errors must be fixed.

Relevant logs:

Nothing special in logs

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing deletion from Admin UI - Users using the listed server and browser setup, then trace the user-deletion request and its error handling. Compare the first undefined error with the subsequent error-invalid-user response; done means deletion reports success consistently without a misleading error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.