RocketChat / RocketChat/Rocket.Chat
Some images are wrong aspect ratio and some .gif files do not play
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Most of the old image uploads from a couple of years ago are stretched or squeezed to the wrong aspect ratio, and some of the new ones too. Certain .gif files do not play until you click on them.
Steps to reproduce:
- If server is multiple years old, check old messages. Otherwise experiment with uploading multiple new ones.
- Upload many .gif files until one does not play.
Expected behavior:
Images all display in the correct resolution.
Actual behavior:
Server Setup Information:
- Version of Rocket.Chat Server: 4.1.1
- Operating System: Ubuntu 18.04.6
- Deployment Method: docker
- Number of Running Instances: 1
- MongoDB Version: v3.6.3
Client Setup Information
- Desktop App or Browser Version: 3.5.7
- Operating System: Arch Linux and Windows 10
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are identified in the issue. Start by reproducing the problem with old messages and multiple new uploads, including GIFs, using the described server and client setups. Done means uploaded images display at the correct aspect ratio and affected GIFs play without requiring a click.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100