RocketChat / RocketChat/Rocket.Chat
Create thumbnails from uploaded images #20907 from v3.18.0 (probably) broke uploaded gif preview
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Looks like the feature Create thumbnails from uploaded images (pull request #20907 ) broke the inline preview for some (but weirdly not all) gifs.
Users were complaining about the issue so I changed "Administation > Message > Message Attachments > Enable image thumbnails to save bandwith" to disabled (it seems it was set by default to "enabled") and now the problem is gone and every gif is animated on all clients (desktop, web, mobile).
Steps to reproduce:
- Drag and drop an animated .gif file from my desktop to a group chat in rocket.chat GUI (in a web browser for instance).
- In the new "File Upload" window click "Send" button.
Expected behavior:
Gif animation should playback immediately.
Actual behavior:
Gif doesn't play. Instead only the first frame is displayed as a static image.
If you click on the (static) "inline" image preview the "fullscreen" preview will appear (with dimmed background) and this "fullscreen" preview will be animated.
Server Setup Information:
- Version of Rocket.Chat Server: 3.18.1
- Operating System: Debian
- Deployment Method: docker
- Number of Running Instances: 1
- DB Replicaset Oplog: ???
- NodeJS Version: v12.22.1
- MongoDB Version: 4.0.27 / mmapv1 (oplog Enabled)
Client Setup Information
- Desktop App or Browser Version: Firefox 92.0.1 (64-bit)
- Operating System: Windows 10 (21H1)
Additional context
Maybe this is also relevant?:
https://github.com/RocketChat/Rocket.Chat/pull/14086
https://github.com/RocketChat/Rocket.Chat.ReactNative/pull/2975
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing pull request #20907 and the thumbnail setting described under Administration > Message > Message Attachments. Reproduce the issue with an animated GIF while thumbnails are enabled, then verify that the inline preview animates immediately while fullscreen preview and other listed clients remain functional.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js, typescript
- Domain
- frontend, full-stack
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100