RocketChat / RocketChat/Rocket.Chat

Custom OAuth login card not showing on /direct/username

Open
#23,214 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Opening a browser window with a direct message to a user does not show custom oauth.

Steps to reproduce:
  1. Open new incognito browser window
  2. Enter address https://chat.milchjugend.ch/direct/QgeC5jsigrAQD2HehqEkB9hQdbnecpeJa7 or https://chat.milchjugend.ch/direct/mahal
Expected behavior:

Shows login card

Actual behavior:

blank screen and error "invalid user"

Server Setup Information:
  • Version of Rocket.Chat Server: 3.17.2
  • Operating System: Linux
  • Deployment Method: snap
  • Number of Running Instances: 1
  • DB Replicaset Oplog: MongoDB 3.6.14 / wiredTiger (oplog Enabled)
  • NodeJS Version: v12.22.1
  • Only custom OAuth enabled, no direct login
  • Database Migration: 228 (September 16, 2021 6:02 AM)
Client Setup Information
  • Desktop App or Browser Version: Firefox, Chrome, Safari
  • Operating System: macOS, Windows
Additional context
Relevant logs:

Server:

I20210916-11:58:34.137(0) server.js:204 System ➔ error Exception while invoking method createDirectMessage Invalid user [error-invalid-user]

Client:

Object { stack: "r@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:1:4173\n_livedata_result@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:736:17821\nonMessage@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:736:20132\nu@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:973:263415\nt/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:973:263545\nn.bindEnvironment/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:1:8262\npromise callback*n/t.makeCompatible/n.prototype.then@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:692:1083\nt@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:973:263515\nsendMessage@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:736:2229\napply@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:736:9725\ncall@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:736:8246\ne/o.call@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:971:656067\ns/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:971:204899\ns@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:971:204877\nT/window.currentTracker<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:971:222869\nasync*_compute@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:2279\nt@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:1410\nn/o.autorun@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:3956\nT@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:971:221856\naction@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:971:145780\nt/g.prototype.callAction@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:10139\ne/f.prototype._buildTracker/</<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:6875\nn/o.nonreactive@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:4139\ne/f.prototype._buildTracker/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:6721\n_compute@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:2279\n_recompute@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:2434\nn/o._runFlush@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:3443\nn/o.flush@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:3060\ne/f.prototype._invalidateTracker@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:7121\na@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:2889\nt/h.runTriggers@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:1508\no._actionHandle@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:2957\nt/y.prototype.middleware/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14843\no@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14263\nt/y.prototype.middleware/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14850\no@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14263\nt/y.prototype.middleware/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14850\no@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14263\nt/y.prototype.middleware/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14850\no@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14263\nt/y.prototype.middleware/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14850\no@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14263\nt/y.prototype.middleware/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14850\no@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14263\nt/y.prototype.middleware/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14850\n", isClientSafe: true, error: "error-invalid-user", reason: "Invalid user", details: {…}, message: "Invalid user [error-invalid-user]", errorType: "Meteor.Error" }
​
details: Object { method: "createDirectMessage" }
​
error: "error-invalid-user"
​
errorType: "Meteor.Error"
​
isClientSafe: true
​
message: "Invalid user [error-invalid-user]"
​
reason: "Invalid user"
​
stack: "r@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:1:4173\n_livedata_result@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:736:17821\nonMessage@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:736:20132\nu@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:973:263415\nt/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:973:263545\nn.bindEnvironment/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:1:8262\npromise callback*n/t.makeCompatible/n.prototype.then@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:692:1083\nt@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:973:263515\nsendMessage@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:736:2229\napply@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:736:9725\ncall@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:736:8246\ne/o.call@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:971:656067\ns/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:971:204899\ns@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:971:204877\nT/window.currentTracker<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:971:222869\nasync*_compute@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:2279\nt@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:1410\nn/o.autorun@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:3956\nT@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:971:221856\naction@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:971:145780\nt/g.prototype.callAction@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:10139\ne/f.prototype._buildTracker/</<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:6875\nn/o.nonreactive@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:4139\ne/f.prototype._buildTracker/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:6721\n_compute@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:2279\n_recompute@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:2434\nn/o._runFlush@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:3443\nn/o.flush@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:724:3060\ne/f.prototype._invalidateTracker@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:7121\na@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:2889\nt/h.runTriggers@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:1508\no._actionHandle@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:2957\nt/y.prototype.middleware/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14843\no@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14263\nt/y.prototype.middleware/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14850\no@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14263\nt/y.prototype.middleware/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14850\no@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14263\nt/y.prototype.middleware/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14850\no@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14263\nt/y.prototype.middleware/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14850\no@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14263\nt/y.prototype.middleware/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14850\no@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14263\nt/y.prototype.middleware/<@https://chat.milchjugend.ch/d229bcc9aa214889724d7c90b55cad16497088aa.js?meteor_js_resource=true:866:14850\n"
​
<prototype>: Object { constructor: r(), clone: clone(), stack: "" }

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the two /direct/... URLs and compare it with /channel/general and the open.rocket.chat example. Start from the server createDirectMessage error and related issue #21735; done means the custom OAuth login card appears for direct-message URLs without producing an invalid-user error.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
authentication, backend, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.