RocketChat / RocketChat/Rocket.Chat

E2E Encryption - Decryption of messages doesn't work in browser client

Open
#23,116 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

After updating rocket chat server do 3.18, decrypting messages in browser doesn't work anymore (even though correct e2e password is provided). It does work in Android rocket chat client though (don't have access to iOS client).

Screenshot 2021-09-06 at 09 01 05

Steps to reproduce:
  1. Enable e2e encryption for channel
  2. Write a message
  3. Message shows encrypted string instead of a decrypted message, even though e2e encryption password is correct.
Expected behavior:

Message should be decrypted.

Actual behavior:

Message shows as encrypted string

Server Setup Information:
  • Version of Rocket.Chat Server: 3.18.0
  • Operating System: Ubuntu 16.04.7
  • Deployment Method: manual
  • Number of Running Instances: 1
  • DB Replicaset Oplog: enabled
  • NodeJS Version: v12.22.5
  • MongoDB Version: v4.4.8
Client Setup Information

Doesn't work for any client that i've tested with other people. Only client that seem to be working is the mobile app.

  • Desktop App or Browser Version: Firefox 91.0.2 (doesn't work on newest safari either, or any other browser, regardless of OS)
  • Operating System: macOS Big Sur
Additional context

It seems it happened after update to 3.18.0, before it was working fine

Relevant logs:

Nothing relevant in logs, no errors. Just normal operation after restarting. Nothing in browser (client) log either.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is identified in the report. Start by reproducing the failure in the browser client on Rocket.Chat Server 3.18.0 with an encrypted channel and the correct password, then compare the behavior with the working Android client. Done means browser clients decrypt channel messages instead of displaying the encrypted string.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.