RocketChat / RocketChat/Rocket.Chat

RC Notification settings not saved once leaving the room

Open
#22,898 5 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Reported here: https://github.com/RocketChat/Rocket.Chat/issues/22537
Upgraded to 3.17, still reproducible

Description:

In the web browser version of RC, when changing alert notification settings in a specific room, they fail to save once leaving the room (this is not an issue on the mobile apps

Steps to reproduce:

Steps to reproduce:

Open RC in a desktop web browser
Go to any room notification settings
Unfold Desktop section
Change Alerts value to any other (e.g. default to Nothing)
Save changes
Swithc current chat room
Return to initial chat room
Check Notification settings

Expected behavior:

Desktop alerts keeps saved setting (e.g. Nothing)

Actual behavior:

Desktop alerts remain the same as before changes (e.g. Default)

Server Setup Information:
  • Version of Rocket.Chat Server: 3.17
  • Operating System: Linux
  • Deployment Method: tar
  • Number of Running Instances: 30-60
  • DB Replicaset Oplog: enabled
  • NodeJS Version: v12.18.4
  • MongoDB Version: 4.0.18
Client Setup Information
  • Desktop App or Browser Version:
    desktop web

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the desktop web browser using the listed room notification steps, then trace how the room's Desktop alert setting is saved and restored after switching rooms. Done means a changed alert value, such as Nothing, remains selected when returning to the room.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.