RocketChat / RocketChat/Rocket.Chat

Wrong number of group mentions in error message

Open
#22,788 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When you post a message in a channel with a mention limit of 500 users, the error message is: "Group mentions (at)all and (at)here have been disabled for rooms with more than 50 members."

Steps to reproduce:
  1. Set mention limit to 500.
  2. Write a message to (at)all users.
Expected behavior:

The error message should show the correct limitation of 500 users.

Actual behavior:

The error message says the limit is 50 users.

Server Setup Information:
  • Version of Rocket.Chat Server: 3.14.4
  • Operating System: Ubuntu 18.04
  • Deployment Method: docker
  • Number of Running Instances: 14
  • DB Replicaset Oplog: yes
  • NodeJS Version: v12.22.1
  • MongoDB Version: 4.0.24
Client Setup Information
  • Desktop App or Browser Version: Firefox 90
  • Operating System: Win 10
Additional context

none

Relevant logs:

none

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by searching the repository for the reported error wording and then trace the group-mention limit handling. Done means the error displays the configured limit, such as 500 instead of a hard-coded 50, and the relevant behavior is covered by an appropriate test.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.