RocketChat / RocketChat/Rocket.Chat
Upload modal box disappear if click is made outside the box, or in the title box
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Using the Web portal, on any channel: If I click the + button to add a picture from my computer, then I choose a file, the modal box will immediately close if I do one of the following:
- click outside of the modal box
- highlight the filename field using a long left clic then release it outside the modal box, when I want to change this text.

Steps to reproduce:
- Go to the web application
- Open a channel if not already
- Click on the bottom right + button then select Computer
- Pick a picture from your computer
- Highlight the filename field using your mouse, by clicking left at the begining of the string then moving over the name, continue until your cursor is out of the white modal box and release your mouse left button
Expected behavior:
The modal box must stay opened if I release my left button outside the upload modal box
It should also stay open if I click outside of it, that could happens by mistake and I will have to redo the upload again.
In fine, only the cancel button should close the modal box.
Actual behavior:
If we click outside the modal box, it closes it without a warning.
If we select a text using the left button of our mouse and release it outside the box, it closes the box without a notice as well.
Server Setup Information:
- Version of Rocket.Chat Server: 3.15.0
- Operating System: Docker (Centos 8)
- Deployment Method: docker
- Number of Running Instances: 1
- DB Replicaset Oplog: 1
- MongoDB Version: 4.0
Client Setup Information
- Desktop App or Browser Version: Google Chrome Version 91.0.4472.101
- Operating System: Windows 10 21H1
Additional context
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the upload flow in the web application: open a channel, choose Computer from the + menu, select an image, and test clicks and drag selections ending outside the modal. Trace the upload modal entry point and its outside-click handling; done means accidental outside clicks or mouse releases no longer close the modal, while Cancel still does.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100