RocketChat / RocketChat/Rocket.Chat

[Teams] Public channel become in fact private if added to Private Team

Open
#22,239 10 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Most common case of using Teams feature, IMHO, is to create a Private Team and add some channels to that Team, including Public Channels of cause. But in that case that Public Channels start behave like Private groups, which is wrong.

Steps to reproduce:
  1. Create Private Team
  2. Add Public Channel to that Private Team
  3. Public Channel not shown in search result, so become a Private Group
  4. In Admin UI that Public Channel remain to be Public Channel
Expected behavior:

Public Channels should remain public if they added to Private Team

Actual behavior:

As on screenshot DevOps Corp is a Private Team and DevOps is Public Channel which was added to DevOps Corp
image
But that DevOps is Public channel not available in Directory Search

Server Setup Information:
  • Version of Rocket.Chat Server: 3.15.0
  • Operating System: CentOS7
  • Deployment Method: docker
  • Number of Running Instances: 25
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 12.22.1
  • MongoDB Version: 4.2.14 WiredTiger
Client Setup Information
  • Desktop App or Browser Version: 3.2.2
  • Operating System: Windows 10
Additional context
Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with a Private Team, a Public Channel, and Directory Search, then compare the channel's visibility in the Admin UI. No source files or tests are named; trace the Teams and Directory Search entry points to identify where team privacy affects public-channel discoverability. Done means the channel remains searchable while retaining its public status.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authorization, search
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.