RocketChat / RocketChat/Rocket.Chat

HTML revealed when searching with some characters

Open
#22,230 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

In message search tab, if I start search with | character, the HTML is revealed in result messages.

Steps to reproduce:
  1. Go to the message search tab
  2. Type |something to search
  3. the result messages found reveals HTML
Expected behavior:

The search should display only messeges

Actual behavior:

The search displays HTML inside result messages

Server Setup Information:
  • Version of Rocket.Chat Server: 3.14.0
  • Operating System:
  • Deployment Method:
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • NodeJS Version:
  • MongoDB Version:
Client Setup Information
  • Desktop App or Browser Version: Chrome 90.0.4430.212
  • Operating System: Mac OS Big Sur
Additional context

I can replicate it on open.rocket.chat

Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the message search tab with a query beginning with |, using the reported Chrome and macOS setup if available. Inspect the search result rendering path and verify that the result displays only message text, not HTML, for this query.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.