RocketChat / RocketChat/Rocket.Chat
Type of parameter "full" being boolean
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
type of parameter
full, atRocket.Chat/client/views/room/lib/Toolbox/index.tsx
export type ToolboxActionConfig = {
id: string;
icon: string;
title: TranslationKey;
anonymous?: boolean;
renderAction?: ActionRenderer;
full?: true; // this type should be boolean I thought
renderOption?: OptionRenderer;
order?: number;
groups: Array<'group' | 'channel' | 'live' | 'direct' | 'direct_multiple' | 'team'>;
hotkey?: string;
action?: (e: MouseEvent<HTMLElement>) => void;
template?: string | FC | LazyExoticComponent<FC<{ rid: string; tabBar: any }>>;
};
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open Rocket.Chat/client/views/room/lib/Toolbox/index.tsx and inspect the ToolboxActionConfig definition and its usages of full. Confirm the intended boolean behavior, then run the relevant TypeScript validation; the issue is done when the type matches the reported parameter behavior without introducing type errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100