RocketChat / RocketChat/Rocket.Chat
Forced Two-Factor Authentication - Even when disabled
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
When adding validated users using rest-api or via interface, the two factor authentication is being forced even when 2fa is disabled.
Steps to reproduce:
- Go to 'Accounts'
- Disable Two-Factor authentications with TOTP
- Disable Two Factor Authentication via Email
- Click Salve changes
- Add new user with "validated email" checked
- Try to login
Expected behavior:
When disabling two-factor authentication, it should not be required to enter a two-factor authentication when logging in.
Actual behavior:
It doesn't matter if you disable the two-factor authentication. The server is always forcing it.
Server Setup Information:
- Version of Rocket.Chat Server: 3.14.0
- Operating System: Centos 7
- Deployment Method: tar
- Number of Running Instances: 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Accounts settings flow in the issue: disable both TOTP and email two-factor authentication, save, create a user with validated email, and log in. Trace the authentication path for that user and verify that disabling both methods prevents any two-factor prompt while preserving the validated-email flow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authentication, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100