RocketChat / RocketChat/Rocket.Chat

Email notification with markdown/html is rendered with raw html

Open
#21,938 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When markdown parser is set to marked and you receive an email notification of a message containing markdown/html, the message is displayed as html tag directly.

Steps to reproduce:
  1. Go to the administration panel, section "Message", "Markdown", choose "Marked"
  2. Configure and activate email notification
  3. Send a message to a channel containing html content and smileys to trigger the email notification
  4. Consult the email received
Expected behavior:

Mail render almost like in rocketchat with smileys and basic formatting working in the mail (Under the condition that you consult the mail in html mode and not plain text).

Example of the expected behavior :

image

Actual behavior:

Smileys render in the ":code:" format.
Raw html is visible
image

Server Setup Information:
  • Version of Rocket.Chat Server: 3.14.0
  • Operating System: Fedora 33 (Docker host)
  • Deployment Method: docker using tag latest
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Don't know how to find this
  • NodeJS Version: v12.22.1
  • MongoDB Version: 4.0.24 / mmapv1 (oplog Enabled)
Client Setup Information
  • Desktop App or Browser Version: Chrome Version 89.0.4389.128 ; Exchange web client using chrome also
  • Operating System: Fedora 32
Additional context

Didn't find anything related to html/mail in the administration.
The instance is almost with no specific config.

Relevant logs:

rocketchat.log

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue using the listed administration settings, message content, and email notification steps, then inspect the received email in HTML mode. Done means basic formatting and smileys render correctly while HTML tags are not shown as raw text and smileys are not left in :code: form.

Written by the indexing model from the issue text.

Assessment

Tech stack
html, markdown
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.