RocketChat / RocketChat/Rocket.Chat
Change input type
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
In CAS, 'Login Popup width' and 'Login popup height' input box should only accept integer value as a correct value. But now its also accepting alphabet value as a correct input.
Steps to reproduce:
- Go to 'Administration' and click on CAS.
- Click on 'CAS Login Layout'.
- Type any alphabets in 'Login Popup width' input box or 'Login Popup Height' inputbox.
Expected behaviour:
Should not accept alphabets as a correct input value and should accept integer value as a correct input.
Actual behavior:
Accept alphabets as a correct input value.
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the Administration > CAS > CAS Login Layout settings and inspect the Login Popup width and Login Popup height inputs. Reproduce the issue with alphabetic and integer values, then verify that only integers are accepted and that the existing settings behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authentication, frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100