RocketChat / RocketChat/Rocket.Chat

Excessive whitespace around unsorted lists in attachment data values

Open
#21,860 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When using markdown to provide an unsorted list inside a data value in an attachment through the postMessage API, there is an excessively large area of whitespace above and below the list.

Steps to reproduce:
  1. Use an API client to send a message that includes a data item with the key "Some key" and the value "* Some text"
Expected behavior:

There is no additional whitespace above what would be seen for a plain text data value

Actual behavior:
rocketchat-markdown-list
Server Setup Information:
  • Version of Rocket.Chat Server: 3.14.0
  • Operating System: Linux (variant unknown, managed by Azure AKS)
  • Deployment Method: Helm 3
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: v12.22.1
  • MongoDB Version: 4.4.5
Client Setup Information
  • Desktop App or Browser Version: Chrome Version 89.0.4389.114 (Official Build)
  • Operating System: MacOS 11.3
Additional context

N/A

Relevant logs:

N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with an API client using the postMessage API and an attachment data value containing "* Some text". Trace how markdown lists in attachment values are rendered, then verify that the list has no excess whitespace compared with a plain-text data value.

Written by the indexing model from the issue text.

Assessment

Tech stack
markdown, typescript
Domain
api, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.