RocketChat / RocketChat/Rocket.Chat

Unable to edit "Custom Emoji"

Open
#21,819 1 comment 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

You can not just edit the name or alias of a custom emoji in administration without modifying the emoji file.

Steps to reproduce:
  1. Go to administration and Custom Emoji
  2. If you don't have an existing custom emoji add it.
  3. Click on any emoji and try to edit just the name or alias.
Expected behaviour:

Name and alias should update

Actual behavior:

Nothing happens on save

https://user-images.githubusercontent.com/69837339/116249894-e1c45d00-a78a-11eb-9b4c-8c87a2db13c8.mov

Server Setup Information:
  • Version of Rocket.Chat Server:
  • Operating System:
  • Deployment Method:
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • NodeJS Version:
  • MongoDB Version:
Client Setup Information
  • Desktop App or Browser Version:
  • Operating System:
Additional context
Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue through Administration > Custom Emoji, then trace the edit and save flow for an existing emoji. The fix is complete when changing only the name or alias saves successfully without requiring a new emoji file; no file or test is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
full-stack
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.