RocketChat / RocketChat/Rocket.Chat
Make it more obvious when 'read direct message' permission is being denied.
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
We ran into a misconfiguration problem with our server earlier -- and found that it was very counterintuitive, that our users' clients simply wouldn't show direct messages. The expectation is that when a permission is denied, you get a message explaining that -- but since there wasn't any such message, it looked like a bug.
Making this permission more obvious by e.g. showing User does not have permission to view direct messages. in the place the chatlog would normally show up, would be ideal.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests. Start by tracing the client-side direct-message visibility and permission check, then reproduce a denied permission and confirm the chat area displays an explanatory message instead of appearing empty.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authorization, frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100