RocketChat / RocketChat/Rocket.Chat
Discussion channels should inherit parent channel private/public when parent is change
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Discussion channels should inherit parent channel private/public when parent is change
Steps to reproduce:
- create a channel (ex public)
- create a discussion in the channel
- edit the channel
- make the channel private
- see if the nested discussion is private as well
Expected behavior:
all the discussions should be changed from public to private
Actual behavior:
changing parent private toggle doesn't affect nested discussions
Server Setup Information:
- Version of Rocket.Chat Server: 3.13.1
- Operating System: ubuntu
- Deployment Method: docker
- Number of Running Instances: 1
Client Setup Information
- Desktop App or Browser Version: Chrome 89
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by tracing the channel edit flow and how nested discussions store their private/public state; reproduce the listed steps, then verify that changing a parent channel updates all of its discussions and that existing public-to-private behavior is covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100