RocketChat / RocketChat/Rocket.Chat

mark-tags affect internet addresses in search

Open
#21,206 5 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When searching for an address there are problems with formatting and the target link. This is issued by the mark-tag.

Steps to reproduce:

Search for

  1. case: rocket.chat/installation
  2. case: "rocket.chat/installation"
  3. case: "https://docs.rocket.chat/installation/mobile-and-desktop-apps"
Expected behavior:

search result should always show and link to https://docs.rocket.chat/installation/mobile-and-desktop-apps

Actual behavior:
  1. case: https://mychat.com/%3Cmark%3Ehttps://docs.rocket.chat/installation%3C/mark%3E/mobile-and-desktop-apps
  2. case: https://docs.rocket.chat/installation/mobile-and-desktop-apps but without partial highlighting
  3. case: the link is "https://docs.rocket.chat/installation/mobile-and-desktop-apps" target="_blank" rel="noopener noreferrer">https://docs.rocket.chat/installation/mobile-and-desktop-apps and the target becomes https://mychat.com/%3Cmark
Server Setup Information:
  • Version of Rocket.Chat Server: 3.12.1
  • Operating System: Ubuntu 18.04
  • Deployment Method: tar
  • Number of Running Instances: 1
  • NodeJS Version: 12.21.0
  • MongoDB Version: 4.0.23
Client Setup Information
  • Desktop App or Browser Version: Any
  • Operating System: Any

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the three search cases from the issue and trace how mark-tags are rendered into search result text and links. Done means each case displays the expected URL, preserves the intended partial highlighting, and does not place mark-tag or link attributes into the target URL.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.