RocketChat / RocketChat/Rocket.Chat

gitlab WebHook messages are not displayed correctly

Open
#21,157 15 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Since the upgrade from 3.9 to 3.12, the display of Gitlab notifications are somewhat not correctly displayed.
It is probably linked to https://github.com/RocketChat/Rocket.Chat/issues/21009 but the behavior is different, and still somewhat incorrect. We never tried the 3.10 version of Rocket.chat.

Steps to reproduce:
  1. Create an incoming integration in rocketchat (without any script)
  2. Create a webhook in gitlab (version 13.9.x)
  3. Fire the webhook in gitlab (push, commit, etc.)
Expected behavior:

Here is what used to be like :
rocketchat-notifications

Actual behavior:

And now :
2021-03-17_10h42_12

Server Setup Information:
  • Version of Rocket.Chat Server: 3.12.1
  • Operating System: Centos 7
  • Deployment Method: npm
  • Number of Running Instances: 1
  • DB Replicaset Oplog: enabled
  • NodeJS Version: v12.18.4
  • MongoDB Version: 3.6.3
Client Setup Information
  • Desktop App or Browser Version: tried on native app, firefox, chrome
  • Operating System: Windows 10
Relevant logs:

Logs are empty

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the display problem with a Rocket.Chat incoming integration and a GitLab 13.9.x webhook, following the listed push or commit steps. Compare the current output with the expected and actual screenshots, and review the related issue #21009 for context. Done means GitLab webhook notifications render correctly again without empty logs.

Written by the indexing model from the issue text.

Assessment

Tech stack
gitlab, typescript
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.