RocketChat / RocketChat/Rocket.Chat

Making Discussion Channel to favourite

Open
#21,041 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: ui/ux triaged
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

If user try to add discussion channel to favourite It don't show any pop-up/message if user is not the part of that Discussion channel

Steps to reproduce:
  1. Try to add any Discussion channel to your favourite (that you are not part of it)
Expected behavior:

At-least we can show any kind alert like pop-up/message

Actual behavior:

it's look like kind of error why i can not mark it favourite

https://user-images.githubusercontent.com/51324264/110456821-02a7f480-80f0-11eb-8e23-4f2fc9cd9eec.mp4

Server Setup Information:
  • Version of Rocket.Chat Server: 3.13.0-develop
  • Operating System: linux
  • Deployment Method:
  • Number of Running Instances:
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 12.18.4 - x64
  • MongoDB Version:4.2.8
Client Setup Information
  • Desktop App or Browser Version:Chorme
  • Operating System:Window 10
Additional context
Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in Chrome with a discussion channel the user has not joined, using the described favorite action. Trace the discussion-channel favorite interaction and verify that attempting it gives a clear alert or message explaining why it cannot be completed.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.