RocketChat / RocketChat/Rocket.Chat

Attachment fields now limited to two columns

Open
#20,971 18 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Hi, it looks like since the 3.11 update the attachments fields are limited to only two columns.
This is making trouble for some of our webhooks as we use a couple of small fields which were placed in a single row before the 3.11 update and now we going to clutter our chat with this useless line wraps.

Steps to reproduce:

Send a message with 8 fields for example.

Expected behavior:

We expect to have the fields in a row till wrapping is needed.

Actual behavior:

Fields are wrapped after the seconds column even if there is much space left.

Server Setup Information:
  • Version of Rocket.Chat Server: 3.12

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue on Rocket.Chat 3.12 with a message containing eight attachment fields, then compare the layout with the expected wrapping behavior described here. Trace the attachment-field rendering code to find why fields wrap after two columns; done means fields remain on one row until available space requires wrapping.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.