RocketChat / RocketChat/Rocket.Chat
[Enhancement] Enable KMS Encryption on S3 Uploads
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Our security policy only allows us to upload objects into S3 that are KMS key encrypted. Please provide option to enter a KMS key for S3 encryption on file uploads.
Steps to reproduce:
Go to Settings.
Click File Upload.
Open S3 Settings.
Expected behavior:
A field should exist to input KMS key.
Actual behavior:
No field exists.
Server Setup Information:
- Version of Rocket.Chat Server: 3.8.0
- Operating System: RHEL
- Deployment Method: Docker
- Number of Running Instances: 3
- DB Replicaset Oplog: Mongo
- NodeJS Version:
- MongoDB Version: 4.4.2
Client Setup Information
- Desktop App or Browser Version: Both
- Operating System: Any
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by tracing Settings > File Upload > S3 Settings and the S3 upload configuration and handler. The work is done when a KMS key can be entered in settings and is used for S3 file uploads, with the relevant upload behavior verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, typescript
- Domain
- backend, cloud, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100