RocketChat / RocketChat/Rocket.Chat

Global Search: Search results always show in current room

Open
#20,574 1 comment 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When Completing a global search, the results includes an indicator as to what room the result is in. This indicator always shows the room in which the search was initiated, even if the result is actually located in another room. Jumping to the result does go to the correct room.

Steps to reproduce:
  1. Enable Global Search (under Settings > Search)
  2. Go back to the UI, and select a room
  3. Search for a string that is located in a room other than the current room.
Expected behavior:

Room name shown in the search results corresponds to the room where the results are found

Actual behavior:

Room name shown is the current selected room.

Server Setup Information:
  • Version of Rocket.Chat Server: 3.10.4
  • Operating System: Ubuntu 20.04
  • Deployment Method: <Docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 12.18.4
  • MongoDB Version: 4.0.20
Client Setup Information
  • Desktop App or Browser Version: RC Client 3.10, Chrome
  • Operating System: WIndows 10
Additional context
Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing Global Search from one room, searching for a string found in another room, and inspect how the result's room indicator is rendered. Done means the indicator names the room containing each result while selecting the result still navigates to the correct room.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.