RocketChat / RocketChat/Rocket.Chat
Federated server can delete remote private groups
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
An administrator can remove a federated channel on a remote system.
Steps to reproduce:
- I have two sites A and B that are connected via federation.
- A shares a private channel with a user from B which is Administrator on site B.
- If B decides to delete the channel, then it is really removed from A
Expected behavior:
A is the owner of the channel, it should not be possible for an admin of site B to remove the channel.
Actual behavior:
As described, B is capable of deleting the remote channel A
Server Setup Information:
- Version of Rocket.Chat Server: 3.9.7
- Operating System: Linux
- Deployment Method: docker
- Number of Running Instances:
- DB Replicaset Oplog:
- NodeJS Version:
- MongoDB Version:
Client Setup Information
- Desktop App or Browser Version:
- Operating System:
Additional context
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the federation setup with sites A and B and a private channel owned by A. Trace the remote channel deletion flow and its administrator authorization checks. Done means an administrator on B cannot delete A's channel, while the owning site retains its expected deletion behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- distributed-systems, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100