RocketChat / RocketChat/Rocket.Chat
Missing phone number validation
Open
Nobody has claimed this yet.
type: improvement
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Phone Number validation should be present and only phone numbers should be allowed in phone field.
Steps to reproduce:
- Contact center, and make a new contact
- No phone number validation is present.
Expected behavior:
Phone number should be validated
Actual behavior:
Phone number is not validated
Server Setup Information:
- Version of Rocket.Chat Server: 3.11.0-develop
- Operating System: Ubuntu
- Deployment Method:
- Number of Running Instances: 1
- DB Replicaset Oplog:
- NodeJS Version: 12.18.4
- MongoDB Version: 4.2.8
Client Setup Information
- Desktop App or Browser Version: Chrome version 87
- Operating System: Ubuntu
Additional context
I can enter anything in phone number field.
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the Contact center flow for creating a new contact and reproduce the phone field behavior described in the issue. Define which phone-number formats are accepted, reject other input, and verify that invalid values cannot be submitted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100