RocketChat / RocketChat/Rocket.Chat

Server URL in quoted messages

Open
#20,477 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When you quote a massage, it is generated as "user connection address"+...+"massage id". If you have 2 different names for the server in nginx (for example, for LAN and public users), your quoted message is not displayed correctly. Don't you think it should generate the "server url from settings"+...+"massage id"?

Steps to reproduce:

(You have 2 names for server - for example rc.lan.com and rc.pub.com. You set rc.lan.com in Rocket.Chat settings)

  1. Go to rc.pub.com
  2. Quote any message
  3. Look at the display of the quoted message
Expected behavior:

The quoted message is displayed correctly.

Actual behavior:

The quoted message is displayed incorrectly.

Server Setup Information:
  • Version of Rocket.Chat Server: any
  • Operating System: RHEL
  • Deployment Method: Manual
Client Setup Information
  • Desktop App or Browser Version: any
  • Operating System: any
Additional context

This can be fixed if the message link is generated from the server url from the settings

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the quoted-message action and how it builds links from the configured server URL; the issue names no source file or test. Reproduce the two-host setup, then verify that quoting from the public host displays the message correctly using the configured URL.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.