RocketChat / RocketChat/Rocket.Chat
Direct reply block in iframe with ?layout=embedded never disappears
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
When direct replying to an user, the reply block remain upon navigation in iframe mode.
Steps to reproduce:
- Launch rocket chat in browser with
?layout=embeddedmode. - Click on an user message an click on
Direct reply - Then navigate to another page by clicking a link or using iframe
gocommand. - The reply block remains forever
Expected behavior:
The reply block should disappear when we leave room
Actual behavior:
The reply block remain
Server Setup Information:
- Version of Rocket.Chat Server: 3.9.4
- Operating System: Linux 4.15.0-132-generic
- Deployment Method: docker
- Number of Running Instances: 1
- DB Replicaset Oplog: On
- NodeJS Version: v12.20.0
- MongoDB Version: 4.0.3
Client Setup Information
- Desktop App or Browser Version: Latest chrome
- Operating System: macOS
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the direct-reply flow in an iframe using ?layout=embedded, then trace what happens to the reply block when navigation occurs through a link or the iframe go command. Done means the reply block disappears when leaving the room.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100