RocketChat / RocketChat/Rocket.Chat
[BUG] Quoted message messageLink doesn't work after changing room name
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
The messageLink generated for quoted messages does not get updated on updating room name.
Steps to reproduce:
- Quote a message
- The timestamp of the quoted message has the href which is supposed to link to the original message.
- Change the room name.
- The timestamp link does not work anymore.
Expected behavior:
The links for the attached messages to be automatically changed to reflect the changed room name.
Actual behavior:
The previously generated link gives an error after room name change.
Server Setup Information:
- Version of Rocket.Chat Server: 3.11.0-develop
- Operating System: Ubuntu 20.10
- Deployment Method: develop
- Number of Running Instances: 1
- DB Replicaset Oplog: Enabled
- NodeJS Version: 12.18.4 - x64
- MongoDB Version: 4.2.8
Client Setup Information
- Desktop App or Browser Version: Chrome Version 87.0.4280.88
- Operating System: Ubuntu 20.10
Additional context
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the quoted-message link failure: quote a message, rename the room, and follow its timestamp link. Trace where the messageLink is generated and how room-name changes are handled; done means the existing quoted-message link still resolves to the original message after the rename.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- full-stack
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100