RocketChat / RocketChat/Rocket.Chat
Add ability to "clear" blocked logins
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Introduce a way to reset failed logon attempt counters for accounts / IPs locked via https://github.com/RocketChat/Rocket.Chat/pull/17783
Steps to reproduce:
- Lock out an account / ip using functionality in https://github.com/RocketChat/Rocket.Chat/pull/17783
- Once clocked out, try to unlock it.
Expected behavior:
There should be an interface somewhere to re-enable specific accounts / IPs without completely disabling lockout functionality
Actual behavior:
No such UI exists
Server Setup Information:
- Version of Rocket.Chat Server: 3.10
- Operating System: Ubuntu 20.04
- Deployment Method: Docker
- Number of Running Instances: 1
- DB Replicaset Oplog: Enabled
- NodeJS Version: 12.18.4
- MongoDB Version: 4.0.20
Client Setup Information
- Desktop App or Browser Version: Client 3.10
- Operating System: Windows 10
Additional context
Suggestions:
- Add a "fail-reset" entry in the server-status table that works to halt the counter similar to successful login
- UI for UserID - Add a "account locked out" flag in the UI for a user (visible and settable by an Admin only, maybe controlled by role)
- UI for IP - Field below "IP Whitelist" that will take an IP, reset that IP once and clear on save.
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the lockout functionality introduced in PR #17783, then inspect the server-status, user-admin, and IP-whitelist areas suggested in the issue. Done means an administrator can reset a selected account or IP without disabling lockout protection, with the behavior covered for both paths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authentication, backend, frontend, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100