RocketChat / RocketChat/Rocket.Chat

The administrator can't delete groups

Open
#20,072 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

triaged
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

I have two administrator accounts a and B

A created groups

B cannot delete the groups created by A

Steps to reproduce:
Expected behavior:

Administrator rights should be removed

Actual behavior:

{"success":false,"error":"The required "roomId" or "roomName" param provided does not match any group [error-room-not-found]","errorType":"error-room-not-found"}

When I modify it to the authToken userid of the creator, success is returned

Server Setup Information:
  • Version of Rocket.Chat Server: 1.16.0
  • Operating System: linux
  • Deployment Method:
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: v12.14.0
  • MongoDB Version:4.0.19
Client Setup Information
  • Desktop App or Browser Version:
  • Operating System:
Additional context
Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files, tests, or entry points are identified in the issue. Reproduce the failure with two administrator accounts, then trace the group-deletion authorization path and the roomId or roomName lookup; done means administrator B can delete a group created by administrator A without weakening permissions for non-administrators.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authorization, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.