RocketChat / RocketChat/Rocket.Chat
Setting home title to empty makes it return an obect instead of string.
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Setting home title empty returns key 'project: (en)' returned an object instead of string.
Steps to reproduce:
- Administration
- Search layout and select content
- Make home title empty
Expected behavior:
Instead of that message we should give a title when home title is empty.
Actual behavior:
Home title is key 'project: (en)' returned an object instead of string.
Server Setup Information:
- Version of Rocket.Chat Server:3.11.0-develop
- Operating System: Ubuntu
- Deployment Method:
- Number of Running Instances:
- DB Replicaset Oplog:
- NodeJS Version: 12.18.4
- MongoDB Version:4.2.8
Client Setup Information
- Desktop App or Browser Version:Chrome
- Operating System:Ubuntu
Additional context
I am working on it.
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue through Administration > Search layout > content by clearing the home title, then trace how the title and the 'project: (en)' localization key are rendered. Done means an empty home title produces a title string instead of an object-return error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend, internationalization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100