RocketChat / RocketChat/Rocket.Chat

New messages move channels from favorite to unread

Open
#19,686 4 comments 0 reactions 1 assignee View on GitHub

@ggazzo is already working on this.

Since Nov 30, 2020.

area: ui/ux
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

As of 3.8.1, favorite channels on the sidebar from the Favorites list to the Unread list when they receive messages. The old behaviour was highlighting the channel name in the Favorites list itself.

Since the favorites list is assumed to be a small one, I find the old behaviour to be preferrable. It makes it easier for the user to prioritise their reading order.

Another option is adding the channel to the Unread list while also keeping it highlighted in the Favorites list.

Steps to reproduce:
  1. Create a new channel
  2. Star/favorite it
  3. Check that it is included in the Favorites sidebar
  4. In View Mode, activate the "Unread on top" option
  5. With another profile, send a message in the created channel
Expected behavior:

The channel name should be highlighted in the Favorites sidebar for the first profile.

Actual behavior:

The channel gets moved from the Favorites sidebar to the Unread sidebar for the first profile

Server Setup Information:
  • Version of Rocket.Chat Server: 3.8.1 (not sure)
  • Operating System: ---
  • Deployment Method: ---
  • Number of Running Instances: ---
  • DB Replicaset Oplog: ---
  • NodeJS Version: ---
  • MongoDB Version: ---
Client Setup Information
  • Desktop App or Browser Version: Mozilla Firefox 83.0 (64-bits)
  • Operating System: Ubuntu Linuz 18.04

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.