RocketChat / RocketChat/Rocket.Chat

Ignored member messages are not always ignored

Open
#19,667 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feat: message
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Sometimes messages of an ignored member leak from threads to main channel as non ignored.

Steps to reproduce:
  1. Ignore a member on channel
  2. Create a message
  3. Answer to message in a thread as an ignored member, select Also send to channel
Expected behavior:

Messages from the ignored member should be ignored completely or at least their content not shown.

Actual behavior:

Message is shown on the main channel non ignored. Message body is shown like the member was not ignored at all.

Server Setup Information:
  • Version of Rocket.Chat Server: 3.8.1
  • Operating System: CentOS7
  • Deployment Method: tar
  • Number of Running Instances: 20
  • DB Replicaset Oplog: yes
  • NodeJS Version: 12.18.4
  • MongoDB Version: 3.6
Client Setup Information

Browser Version: Firefox, Chrome

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue using the listed steps: ignore a channel member, have that member reply in a thread, and select “Also send to channel.” Trace the handling of ignored-member thread replies and verify that the reply is either omitted from the main channel or its content remains hidden.

Written by the indexing model from the issue text.

Assessment

Tech stack
mongodb, nodejs, typescript
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.