RocketChat / RocketChat/Rocket.Chat

Whitespace is not permit for search users on Channel create/modificate

Open
#19,610 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Whitespace is not permit for search (in field 'name') on create/modificate channel (input "Invite Users")
We use "real_name" feature on 'layout / user interface' so search with white space in field 'name' is imperative for us.

Steps to reproduce:
  1. Click to Create new Channel
  2. Add new user without a Whitespace character (because Whitespace is not authorized) to Channel in input 'Invite Users'
  3. Impossible to find a correct user for large directory because without possibility to use Whitespace result is too large

OR

  1. Click to a Channel already exist
  2. Click to Members submenu
  3. Click to '+ Add users'
  4. Add new user without a Whitespace character (because Whitespace is not authorized) to Channel in input 'Invite Users'
  5. Impossible to find a correct user for large directory because without possibility to use Whitespace result is too large
Expected behavior:

Permit search with Whitespace in input "Invite Users" for Channel create/modificate

Actual behavior:

Do not permit Whitespace in search input "Invite Users" for Channel create/modificate

Server Setup Information:
  • Version of Rocket.Chat Server: 3.8.0
  • Operating System: Linux debian buster
  • Deployment Method: from source
  • Number of Running Instances: 3
  • DB Replicaset Oplog: 1
  • NodeJS Version: v12.18.4
  • MongoDB Version: 4.2.10
Client Setup Information
  • Desktop App or Browser Version: Chrome / Firefox / Desktop app
  • Operating System: Linux
Additional context
Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the channel creation and channel Members flows, then reproduce the Invite Users search with a whitespace-containing user name. Trace the frontend search entry point and its tests, if present; done means users can search by whitespace-containing names in both channel creation and adding members.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.