RocketChat / RocketChat/Rocket.Chat
Registration shows on invite even though registration is disabled
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
I have set "Registration form" to "Disabled", and entering the URL, the link is correctly gone from the login form.
However, if i go to a private group, and issue a invitation link, the link sends me to a login form where the registration link appears again. The link seems not to be active though, as nothing happens when clicked.
Steps to reproduce:
- In admin section - Accounts --> Registration set "Registration form" to "disabled"
- Go to URL of chat to verify in login form link to registration is removed
- Enter a private group and generate an invite link
- Access the invite link in a URL - link to registration is back
Expected behavior:
The link to registration should be removed when registration form is set to disabled.
Actual behavior:
Server Setup Information:
- Version of Rocket.Chat Server:
- Operating System: 3.6.2
- Deployment Method: snap
- Number of Running Instances: 1
- DB Replicaset Oplog:
- NodeJS Version: 12.16.1
- MongoDB Version: 3.16.4
Client Setup Information
- Desktop App or Browser Version: app , 2.17.11
- Operating System: Windows 10
Additional context
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue through a private-group invitation link after disabling the Registration form in Admin > Accounts > Registration. Compare the invite-link login form with the regular login form; done means the registration link is absent or consistently inactive when registration is disabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authentication, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100