RocketChat / RocketChat/Rocket.Chat
CursorNotFound on LDAP import
Open
Nobody has claimed this yet.
area: authentication
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
LDAP import fails to finish
Steps to reproduce:
- Run LDAP import
Expected behavior:
No crash
Actual behavior:
Crash
Server Setup Information:
- Version of Rocket.Chat Server: 3.7.1
- Operating System: Debian 10
- Deployment Method: tar
- Number of Running Instances: 1
- DB Replicaset Oplog: ??
- NodeJS Version: 12.18.1-1nodesource1
- MongoDB Version: 4.2.8
Client Setup Information
- Desktop App or Browser Version:
- Operating System:
Additional context
Relevant logs:
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: server.js:204 LDAPSync ➔ error MongoError: cursor id 1850802509835155859 not found
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at Connection.<anonymous> (/opt/Rocket.Chat/programs/server/npm/node_modules/meteor/npm-mongo/node_modules/mongodb/lib/core/connection/pool.js:451:61)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at Connection.emit (events.js:210:5)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at Connection.EventEmitter.emit (domain.js:475:20)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at processMessage (/opt/Rocket.Chat/programs/server/npm/node_modules/meteor/npm-mongo/node_modules/mongodb/lib/core/connection/connection.js:452:10)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at Socket.<anonymous> (/opt/Rocket.Chat/programs/server/npm/node_modules/meteor/npm-mongo/node_modules/mongodb/lib/core/connection/connection.js:621:15)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at Socket.emit (events.js:210:5)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at Socket.EventEmitter.emit (domain.js:475:20)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at addChunk (_stream_readable.js:309:12)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at readableAddChunk (_stream_readable.js:290:11)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at Socket.Readable.push (_stream_readable.js:224:10)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at TCP.onStreamRead (internal/stream_base_commons.js:182:23)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: => awaited here:
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at Function.Promise.await (/opt/Rocket.Chat/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:56:12)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at packages/mongo/mongo_driver.js:1073:14
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at /opt/Rocket.Chat/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: => awaited here:
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at Promise.await (/opt/Rocket.Chat/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:60:12)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at SynchronousCursor._nextObject (packages/mongo/mongo_driver.js:1122:38)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at SynchronousCursor.forEach (packages/mongo/mongo_driver.js:1136:22)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at Cursor.<computed> [as forEach] (packages/mongo/mongo_driver.js:918:44)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at sync (app/ldap/server/sync.js:574:10)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at MethodInvocation.ldap_sync_now (app/ldap/server/syncUsers.js:24:3)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at MethodInvocation.methodsMap.<computed> (app/lib/server/lib/debug.js:67:34)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1771:12)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at packages/ddp-server/livedata_server.js:719:19
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at packages/ddp-server/livedata_server.js:717:46
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at packages/ddp-server/livedata_server.js:715:46
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at new Promise (<anonymous>)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at Session.method (packages/ddp-server/livedata_server.js:689:23)
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: at packages/ddp-server/livedata_server.js:559:43 {
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: operationTime: Timestamp { _bsontype: 'Timestamp', low_: 12, high_: 1604187535 },
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: ok: 0,
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: code: 43,
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: codeName: 'CursorNotFound',
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: '$clusterTime': {
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: clusterTime: Timestamp { _bsontype: 'Timestamp', low_: 12, high_: 1604187535 },
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: signature: { hash: [Binary], keyId: 0 }
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: },
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: name: 'MongoError'
Nov 1 00:38:57 srv-rocket-test rocketchat[15817]: }
Nov 1 00:38:58 srv-rocket-test rocketchat[15817]: server.js:204 LDAP ➔ Search.info Idle
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at app/ldap/server/sync.js:574, where the CursorNotFound stack trace points, and follow the call from app/ldap/server/syncUsers.js:24. Reproduce an LDAP import with the reported Node.js and MongoDB versions, then verify that the import finishes without the reported cursor crash.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mongodb, node.js
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100