RocketChat / RocketChat/Rocket.Chat

[BUG] Non-latin search issues

Open
#19,344 9 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

There is a couple bugs in Admin UI - Rooms search (maybe in some other place too, but now I'm talking about Rooms) with non-Latin search query (Cyrillic in my case).

Steps to reproduce:
  1. Enable UTF8 Names Validation on Admin UI - General
  2. Enable Allow Special Characters in Room Names on Admin UI - Layout - User Interface
  3. Create channel and private room with Cyrillic names, like тестовый канал and тестовый чат
  4. Go to Admin UI - Rooms and try to find that room and channel
Expected behavior:

Non-Latin search should work in every search field in Rocket Chat interface

Actual behavior:

UTF8 Names Validation
image
Allow Special Characters in Room Names
image
Private room and channel with Cyrillic names
image
Search attempts
image
image
Transliteration search works fine
image
image

And a very bad thing - internal transliteration name now not shown in Room Info (it was in 3.1.1 server version)
image
image

And another one issue is that Discussion check box have AND logic but not OR logic (as it should be)
Here is an illustrative screenshot
image
image

Server Setup Information:
  • Version of Rocket.Chat Server: 3.7.1
  • Operating System: CentOC7
  • Deployment Method: docker
  • Number of Running Instances: 12
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: v12.18.4
  • MongoDB Version: 4.0.19
Client Setup Information
  • Desktop App or Browser Version: Chrome 85
  • Operating System: Windows 10
Additional context

So, in that issue actually 3 bugs:

  • Cyrillic search doesn't work in Rooms
  • No internal name of room that was in Room Info in previous versions
  • Discussions checkbox logic is incorrect (AND instead of proper OR)

@ggazzo and all Front-End team, please take a look at that issue.
Thanks!

Relevant logs:

No logs

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the three reported problems in Admin UI - Rooms: search for Cyrillic-named rooms with the two listed settings enabled, inspect Room Info, and test the Discussions checkbox behavior. Done means non-Latin searches work, the internal room name appears in Room Info, and the checkbox uses the expected OR logic.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, internationalization, search
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.