RocketChat / RocketChat/Rocket.Chat

Black Page on certain links (ie: Twitter)

Open
#19,294 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: ui/ux message rendering type: bug
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When posting a twitter link, the "description" automatically added below contain the text, a link to the image, and the date (with its permalink url).
Clicking on the image or date link does nothing or let RocketChat in a black page (no server/room/discussion are visible anymore).

Steps to reproduce:
  1. post a twitter.com link
  2. click on the date/image link
  3. get a black page within the RC Window
Expected behavior:

Openning the link on the default browser

Actual behavior:

Black page, see :
image
image

Server Setup Information:
  • Version of Rocket.Chat Server: 3.6.2
  • Operating System: Ubuntu 18.04
  • Deployment Method: snap
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: 12.16.1 - x64
  • MongoDB Version: 3.6.14
  • Proxy: caddy
Client Setup Information
  • Desktop App or Browser Version: 2.11.0 & 3.x (until 3.0.4 tested)
  • Operating System: Windows 10
Additional context

https://github.com/RocketChat/Rocket.Chat.Electron/issues/1832

Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Twitter-link image or date click in the Rocket.Chat desktop app, then read the related Rocket.Chat.Electron issue 1832 for existing investigation. Done means those links open in the default browser instead of leaving a black page in the Rocket.Chat window.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.